CASSGO-46 Merge ring and ringDescriber #1849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only used once in Session init(), but init is only called once and it does not make sense to do round robin there.
|
FYI @dkropachev |
|
I haven't fully looked at this yet but I do think there's merit in cleaning up the code related to host metadata. As we're currently working on the 2.0 release and this PR seems mostly focused on code quality I think this is probably a good issue/PR to look at after we're done with 2.0 development, can you create a JIRA for this? |
@joao-r-reis What steps should I take to be able to do that? I see that public signup is disabled |
I've created a JIRA for this: CASSGO-46. If you want to continue contributing in the future you can use this link to request a JIRA account. |
joao-r-reis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had two separate structs to store hosts data.
This PR merges both of them and additionally does some refactoring like removing unnecessary methods/structs. The goal is to improve the code logic to make it easier to work with and understand. Having hosts metadata in so many places all over the driver can be confusing and this PR aims to fix it.